netdev - Re: [PATCH ethtool 2/2] ethtool: Add support for control of RX flow hash indirection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1278000225.2082.15.camel@achroite.uk.solarflarecom.com>
Date:	Thu, 01 Jul 2010 17:03:45 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jeff Garzik <jgarzik@...hat.com>
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH ethtool 2/2] ethtool: Add support for control of RX
 flow hash indirection

On Wed, 2010-06-30 at 16:13 +0100, Ben Hutchings wrote:
> Many NICs use an indirection table to map an RX flow hash value to one
> of an arbitrary number of queues (not necessarily a power of 2).  It
> can be useful to remove some queues from this indirection table so
> that they are only used for flows that are specifically filtered
> there.  It may also be useful to weight the mapping to account for
> user processes with the same CPU-affinity as the RX interrupts.
[...]
> +	printf("RX flow hash indirection table for %s with %llu RX ring(s):\n",
> +	       devname, ring_count.data);
> +	for (i = 0; i < indir->size; i++) {
> +		if (i % 8 == 0)
> +			printf("%5zu: ", i);
> +		printf(" %5u", indir->ring_index[i]);
> +		if (i % 8 == 7)
> +			fputc('\n', stdout);
> +	}
[...]

The "%5zu: " above should be "%5u: ".  I can either send another patch
or leave you to fix this up, as you prefer.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html