netdev - Re: [PATCH] s2io: resolve statistics issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100702.223005.246533917.davem@davemloft.net>
Date:	Fri, 02 Jul 2010 22:30:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jon.mason@...r.com
Cc:	netdev@...r.kernel.org, Ramkrishna.Vepa@...r.com,
	Sivakumar.Subramani@...r.com, Sreenivasa.Honnur@...r.com,
	mschmidt@...hat.com
Subject: Re: [PATCH] s2io: resolve statistics issues

From: Jon Mason <jon.mason@...r.com>
Date: Fri, 2 Jul 2010 14:13:49 -0500

> This patch resolves a number of issues in the statistics gathering of
> the s2io driver.
> 
> On Xframe adapters, the received multicast statistics counter includes
> pause frames which are not indicated to the driver.  This can cause
> issues where the multicast packet count is higher than what has actually
> been received, possibly higher than the number of packets received.
>     
> The driver software counters are replaced with the adapter hardware
> statistics for rx_packets, rx_bytes, and tx_bytes.  It also uses the
> overflow registers to determine if the statistics wrapped the 32bit
> register (removing the window of having a statistic value less than the
> previous call).  rx_length_errors statistic now includes undersized
> packets in addition to oversized packets in its counting.  Finally,
> rx_crc_errors are now being counted.
>     
> Signed-off-by: Jon Mason <jon.mason@...r.com>

Looks good, applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html