[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100705120617.GA6267@gondor.apana.org.au>
Date: Mon, 5 Jul 2010 20:06:17 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Eric Dumazet <eric.dumazet@...il.com>
Cc: yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Stephen Hemminger <shemminger@...tta.com>
Subject: Re: Fwd: Possible bug in net/ipv4/route.c?
Eric Dumazet <eric.dumazet@...il.com> wrote:
>
>> 2) The layer using skb->cb[] should clear this area after use and
>> before handing the skb to another layer. Ubicom should modify the
>> driver to clear the skb->cb[] area before sending it up the line.
>>
>
> This is the right option. If you use one word in cb[], only your driver
> knows how to clear it efficiently.
Absolutely not! No protocol stack should rely on an external skb
having a zero cb.
Please fix the bridge instead as it's doing the IP injection.
Cheers,
--
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists