[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20100705.200724.45878250.davem@davemloft.net>
Date: Mon, 05 Jul 2010 20:07:24 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: herbert@...dor.apana.org.au
Cc: frank.arnold@....com, shemminger@...tta.com,
yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org
Subject: Re: bridge br_multicast: BUG: unable to handle kernel NULL pointer
dereference
From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Tue, 6 Jul 2010 08:50:08 +0800
> On Tue, Jul 06, 2010 at 08:48:35AM +0800, Herbert Xu wrote:
>>
>> bridge: Restore NULL check in br_mdb_ip_get
>
> Resend with proper attribution.
>
> bridge: Restore NULL check in br_mdb_ip_get
>
> Somewhere along the line the NULL check in br_mdb_ip_get went
> AWOL, causing crashes when we receive an IGMP packet with no
> multicast table allocated.
It got removed by:
--------------------
commit 8ef2a9a59854994bace13b5c4f7edc2c8d4d124e
Author: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Date: Sun Apr 18 12:42:07 2010 +0900
bridge br_multicast: Make functions less ipv4 dependent.
Introduce struct br_ip{} to store ip address and protocol
and make functions more generic so that we can support
both IPv4 and IPv6 with less pain.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
--------------------
> This patch restores it and ensures all br_mdb_*_get functions
> use it.
>
> Reported-by: Frank Arnold <frank.arnold@....com>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists