netdev - Re: [PATCH] drivers/net: correct valid flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1007060707460.30668@ask.diku.dk>
Date:	Tue, 6 Jul 2010 07:07:57 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drivers/net: correct valid flag

On Mon, 5 Jul 2010, David Miller wrote:

> From: Julia Lawall <julia@...u.dk>
> Date: Mon, 5 Jul 2010 17:07:15 +0200 (CEST)
> 
> > From: Julia Lawall <julia@...u.dk>
> > 
> > Elsewhere in the "optimized" functions, the "2" constants are used.
> > NV_TX_VALID and NV_TX2_VALID have the same value.
> > 
> > Signed-off-by: Julia Lawall <julia@...u.dk>
> > 
> > ---
> > diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
> > index 268ea4d..870c18b 100644
> > --- a/drivers/net/forcedeth.c
> > +++ b/drivers/net/forcedeth.c
> > @@ -2468,7 +2468,8 @@ static int nv_tx_done_optimized(struct net_device *dev, int limit)
> >  	struct ring_desc_ex* orig_get_tx = np->get_tx.ex;
> >  
> >  	while ((np->get_tx.ex != np->put_tx.ex) &&
> > -	       !((flags = le32_to_cpu(np->get_tx.ex->flaglen)) & NV_TX_VALID) &&
> > +	       !((flags = le32_to_cpu(np->get_tx.ex->flaglen)) & NV_TX2_VALID)
> > +	       &&
> >  	       (tx_work < limit)) {
> 
> Please don't put that "&&" on a line by itself.  I don't care if leaving it
> on the previous line makes it exceed 80 columns, what you're doing here is
> infinitely less pleasant to read.

OK, I'll put it back.

julia
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html