netdev - Re: [PATCH v2 1/9] atm: propagate signal changes via notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100706152950.1ace642d@thirdoffive.cmf.nrl.navy.mil>
Date:	Tue, 6 Jul 2010 15:29:50 -0400
From:	chas williams - CONTRACTOR <chas@....nrl.navy.mil>
To:	Karl Hiramoto <karl@...amoto.org>
Cc:	linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org,
	nathan@...verse.com.au
Subject: Re: [PATCH v2 1/9] atm: propagate signal changes via notifier

On Mon,  5 Jul 2010 10:45:53 +0200
Karl Hiramoto <karl@...amoto.org> wrote:


> +void atm_dev_signal_change(struct atm_dev *dev, char signal)
> +{
> +	int i;
> +	pr_debug("%s signal=%d dev=%p number=%d dev->signal=%d\n",
> +		__func__, signal, dev, dev->number, dev->signal);
> +
> +	/* atm driver sending invalid signal */
> +	WARN_ON(signal < ATM_PHY_SIG_LOST || signal >
> ATM_PHY_SIG_FOUND); +
> +	if (dev->signal == signal)
> +		return; /* no change */
> +
> +	dev->signal = signal;
> +
> +	blocking_notifier_call_chain(&atm_dev_notify_chain, signal,
> dev); +}
> +EXPORT_SYMBOL(atm_dev_signal_change);


net/atm/common.c: In function 'atm_dev_signal_change':
net/atm/common.c:213: warning: unused variable 'i'

please remove i unless you need it
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html