netdev - Re: [PATCH net-next-2.6 V2] net: fix 64 bit counters on 32 bit arches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 07 Jul 2010 14:36:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	bhutchings@...arflare.com, shemminger@...tta.com, arnd@...db.de,
	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH net-next-2.6 V2] net: fix 64 bit counters on 32 bit
 arches

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 05 Jul 2010 22:05:22 +0200

> [PATCH net-next-2.6 V2] net: fix 64 bit counters on 32 bit arches
> 
> There is a small possibility that a reader gets incorrect values on 32
> bit arches. SNMP applications could catch incorrect counters when a
> 32bit high part is changed by another stats consumer/provider.
> 
> One way to solve this is to add a rtnl_link_stats64 param to all 
> ndo_get_stats64() methods, and also add such a parameter to
> dev_get_stats().
> 
> Rule is that we are not allowed to use dev->stats64 as a temporary
> storage for 64bit stats, but a caller provided area (usually on stack)
> 
> Old drivers (only providing get_stats() method) need no changes.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Looks great, applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html