netdev - Re: [PATCH v3] vlan: allow TSO setting on vlan interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100708.231058.245410427.davem@davemloft.net>
Date:	Thu, 08 Jul 2010 23:10:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: [PATCH v3] vlan: allow TSO setting on vlan interfaces

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 08 Jul 2010 19:25:48 +0100

> On Thu, 2010-07-08 at 18:37 +0200, Eric Dumazet wrote:
>> When we need to shape traffic using low speeds, we need to
>> disable tso on network interface :
>> 
>> ethtool -K eth0.2240 tso off
>> 
>> It seems vlan interfaces miss the set_tso() ethtool method.
>> 
>> Before enabling TSO, we must check real device supports 
>> TSO for VLAN-tagged packets and enables TSO.
>> 
>> Note that a TSO change on real device propagates TSO setting
>> on all vlans, even if admin selected a different TSO setting.
>> 
>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>

Ok, just to clarify, I'll make sure I get this version instead of "v2"
which I just replied to :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html