netdev - Re: [PATCH] act_nat: not all of the ICMP packets need an IP header payload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100712.200212.235693051.davem@davemloft.net>
Date:	Mon, 12 Jul 2010 20:02:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	xiaosuo@...il.com, hadi@...erus.ca, rpartearroyo@...entia.com,
	herbert@...dor.apana.org.au, ipichel@...entia.com,
	nmoron@...entia.com, netdev@...r.kernel.org
Subject: Re: [PATCH] act_nat: not all of the ICMP packets need an IP header
 payload

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 10 Jul 2010 08:22:33 +0200

> Rodrigo spent lot of time to find the problem and is willing to fix it.

I gave Rodrigo suitable credit in the final commit message.

--------------------
>From 70c2efa5a32a7d38e66224844032160317fa7887 Mon Sep 17 00:00:00 2001
From: Changli Gao <xiaosuo@...il.com>
Date: Fri, 9 Jul 2010 15:33:25 +0000
Subject: [PATCH] act_nat: not all of the ICMP packets need an IP header payload
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

not all of the ICMP packets need an IP header payload, so we check the length
of the skbs only when the packets should have an IP header payload.

Based upon analysis and initial patch by Rodrigo Partearroyo González.

Signed-off-by: Changli Gao <xiaosuo@...il.com>
Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
--------------------
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html