netdev - Re: [PATCH] tc35815: fix iomap leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100713.221428.74744945.anemo@mba.ocn.ne.jp>
Date:	Tue, 13 Jul 2010 22:14:28 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	segooon@...il.com
Cc:	kernel-janitors@...r.kernel.org, davem@...emloft.net,
	jpirko@...hat.com, eric.dumazet@...il.com, adobriyan@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] tc35815: fix iomap leak

On Sat, 10 Jul 2010 14:03:18 +0400, Kulikov Vasiliy <segooon@...il.com> wrote:
> If tc35815_init_one() fails we must unmap mapped regions.
> 
> Signed-off-by: Kulikov Vasiliy <segooon@...il.com>
> ---
>  drivers/net/tc35815.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)

No, pcim_xxx APIs are _managed_ interfaces.  These resources are
released automatically.  Actually currently nobody in kernel call
pcim_iounmap_regions() now.

And _if_ there is any reason to call pcim_iounmap_regions()
explicitly, it should be called in tc35815_remove_one() too.

So, NAK.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html