netdev - Re: [PATCHv2 NEXT 1/5] qlcnic: fix pause params setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100713.230909.104045607.davem@davemloft.net>
Date:	Tue, 13 Jul 2010 23:09:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	amit.salecha@...gic.com
Cc:	netdev@...r.kernel.org, ameen.rahman@...gic.com,
	rajesh.borundia@...gic.com
Subject: Re: [PATCHv2 NEXT 1/5] qlcnic: fix pause params setting

From: amit.salecha@...gic.com
Date: Tue, 13 Jul 2010 22:54:49 -0700

> From: Rajesh Borundia <rajesh.borundia@...gic.com>
> 
> Turning off rx pause param and autoneg param is not supported so
> return error in that case.
> 
> Signed-off-by: Rajesh Borundia <rajesh.borundia@...gic.com>
> Signed-off-by: Amit Kumar Salecha <amit.salecha@...gic.com>
> ---
>  drivers/net/qlcnic/qlcnic_ethtool.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/qlcnic/qlcnic_ethtool.c b/drivers/net/qlcnic/qlcnic_ethtool.c
> index baf5a52..8599993 100644
> --- a/drivers/net/qlcnic/qlcnic_ethtool.c
> +++ b/drivers/net/qlcnic/qlcnic_ethtool.c
> @@ -578,8 +578,13 @@ qlcnic_set_pauseparam(struct net_device *netdev,
>  		}
>  		QLCWR32(adapter, QLCNIC_NIU_GB_PAUSE_CTL, val);
>  	} else if (adapter->ahw.port_type == QLCNIC_XGBE) {
> +
> +		if (!pause->rx_pause || pause->autoneg)
> +			return -EOPNOTSUPP;

There is no reason to add an empty line at the beginning of this
code block, please remove it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html