netdev - Re: [RFC PATCH]: Fix a warning in the niu driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100714.112800.189702548.davem@davemloft.net>
Date:	Wed, 14 Jul 2010 11:28:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	prarit@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC PATCH]: Fix a warning in the niu driver

From: Prarit Bhargava <prarit@...hat.com>
Date: Wed, 14 Jul 2010 09:18:31 -0400

> Dave, would it be acceptable if I then wrapped link in
> uninitialized_var() to get rid of the warning I'm trying to resolve?  It
> seems that your patch then checks for a valid page value so it should be
> okay.

If the patch I posted doesn't fix your warning, the compiler is broken.

Any code path that would not initialize the variable, hits the BUG()
therefore making return from the function completely unreachable,
therefore the uses of the initialized variable are completely unreachable.

I'm not adding workarounds for compiler warning bugs.  They aren't real
bugs, and such efforts tend to _add_ bugs to the tree rather than fix
real problems.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html