netdev - Re: [PATCH] ibmveth: lost IRQ while closing/opening device leads to service loss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100716.131631.184859877.davem@davemloft.net>
Date:	Fri, 16 Jul 2010 13:16:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rcj@...ux.vnet.ibm.com
Cc:	netdev@...r.kernel.org, santil@...ux.vnet.ibm.com,
	brking@...ux.vnet.ibm.com
Subject: Re: [PATCH] ibmveth: lost IRQ while closing/opening device leads
 to service loss

From: Robert Jennings <rcj@...ux.vnet.ibm.com>
Date: Fri, 16 Jul 2010 09:57:25 -0500

> The order of freeing the IRQ and freeing the device in firmware
> in ibmveth_close can cause the adapter to become unusable after a
> subsequent ibmveth_open.  Only a reboot of the OS will make the
> network device usable again. This is seen when cycling the adapter
> up and down while there is network activity.
> 
> There is a window where an IRQ will be left unserviced (H_EOI will not
> be called).  The solution is to make a VIO_IRQ_DISABLE h_call, free the
> device with firmware, and then call free_irq.
> 
> Signed-off-by: Robert Jennings <rcj@...ux.vnet.ibm.com>

Applied, thanks.

> No changes to the patch, I realized I left out '[PATCH]' in the subject
> and I didn't want any automated tools missing this fix.

Rules may be sometimes seen as anal, but they are not _that_ anal.

Also you can always look in patchwork to see if your change is
there, and your original patch was.

You actually make more work for me if you resubmit patches already
sitting in the queue :-/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html