netdev - Re: [PATCH 1/2] bnx2: allocate with GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100715.202537.116398412.davem@davemloft.net>
Date:	Thu, 15 Jul 2010 20:25:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	sgruszka@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] bnx2: allocate with GFP_KERNEL flag on RX path init

From: "Michael Chan" <mchan@...adcom.com>
Date: Thu, 15 Jul 2010 07:48:40 -0700

> Stanislaw Gruszka wrote:
> 
>> Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>
>> ---
>> @@ -2974,7 +2974,7 @@ bnx2_rx_skb(struct bnx2 *bp, struct
>> bnx2_rx_ring_info *rxr, struct sk_buff *skb,
>>       int err;
>>       u16 prod = ring_idx & 0xffff;
>>
>> -     err = bnx2_alloc_rx_skb(bp, rxr, prod);
>> +     err = bnx2_alloc_rx_skb(bp, rxr, prod, GFP_KERNEL);
> 
> This should be GFP_ATOMIC since it is called from NAPI softirq
> context.

This fatal issue gives me doubts about whether this patch was even
tested at all.

Immediately the kernel memory allocator should have issued a warning
due to this GFP_KERNEL allocation in a non-sleep'able context.

Stanislaw, how did you test this patch?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html