netdev - Re: [PATCH] Drivers: net: 8139cp: Fixed 28 style errors, and 119 warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C3FAE6F.3020406@garzik.org>
Date:	Thu, 15 Jul 2010 20:57:19 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Joseph Kogut <joseph.kogut@...il.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers: net: 8139cp: Fixed 28 style errors, and 119
  warnings.


> -/* The following settings are log_2(bytes)-4:  0 == 16 bytes .. 6==1024, 7==end of packet. */
> -#define RX_FIFO_THRESH         5       /* Rx buffer level before first PCI xfer.  */
> +/* The following settings are log_2(bytes)-4:  0 == 16 bytes .. 6 == 1024, 7 == end of packet. */
> +#define RX_FIFO_THRESH         5       /* Rx buffer level before first PCI xfer. */

useless noise

> -       unsigned                wol_enabled : 1; /* Is Wake-on-LAN enabled? */
> +       unsigned                wol_enabled:1; /* Is Wake-on-LAN enabled? */

not an improvement

> -               if (wol->wolopts & WAKE_PHY)    options |= LinkUp;
> -               if (wol->wolopts & WAKE_MAGIC)  options |= MagicPacket;
> +               if (wol->wolopts & WAKE_PHY)
> +                       options |= LinkUp;
> +               if (wol->wolopts & WAKE_MAGIC)
> +                       options |= MagicPacket;

ditto

> -               if (wol->wolopts & WAKE_UCAST)  options |= UWF;
> -               if (wol->wolopts & WAKE_BCAST)  options |= BWF;
> -               if (wol->wolopts & WAKE_MCAST)  options |= MWF;
> +               if (wol->wolopts & WAKE_UCAST)
> +                       options |= UWF;
> +               if (wol->wolopts & WAKE_BCAST)
> +                       options |= BWF;
> +               if (wol->wolopts & WAKE_MCAST)
> +                       options |= MWF;

ditto
>
> -       if (options & UWF)           wol->wolopts |= WAKE_UCAST;
> -       if (options & BWF)           wol->wolopts |= WAKE_BCAST;
> -       if (options & MWF)           wol->wolopts |= WAKE_MCAST;
> +       options        = cpr8(Config5);
> +       if (options & UWF)
> +               wol->wolopts |= WAKE_UCAST;
> +       if (options & BWF)
> +               wol->wolopts |= WAKE_BCAST;
> +       if (options & MWF)
> +               wol->wolopts |= WAKE_MCAST;

ditto

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html