| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 17 Jul 2010 16:35:38 -0700 (PDT) From: David Miller <davem@...emloft.net> To: sbhatewara@...are.com Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, pv-drivers@...are.com, ronghua@...are.com, matthieu@...are.com Subject: Re: [PATCH 2.6.35-rc1] net-next: vmxnet3 fixes [4/5] Do not reset when the device is not opened From: Shreyas Bhatewara <sbhatewara@...are.com> Date: Fri, 16 Jul 2010 01:17:29 -0700 (PDT) > > > On Thu, 15 Jul 2010, David Miller wrote: > >> From: Shreyas Bhatewara <sbhatewara@...are.com> >> Date: Thu, 15 Jul 2010 18:20:52 -0700 (PDT) >> >> > Is this what you suggest : >> > >> > --- >> > >> > Hold rtnl_lock to get the right link state. >> >> It ought to work, but make sure that it is legal to take the >> RTNL semaphore in all contexts in which this code block >> might be called. >> > > This code block is called only from the workqueue handler, which runs in > process context, so it is legal to take rtnl semaphore. > Tested this code by simulating event interrupts (which schedule this > code) at considerable frequency while the interface was brought up and > down in a loop. Similar stress testing had revealed the bug originally. Awesome, please submit this formally. The copy you sent lacked a commit message and signoff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists