netdev - Re: [PATCH 5/5] net: dccp: fix sign bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100718.150734.22057785.davem@davemloft.net>
Date:	Sun, 18 Jul 2010 15:07:34 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	segooon@...il.com
Cc:	kernel-janitors@...r.kernel.org, acme@...stprotocols.net,
	gerrit@....abdn.ac.uk, dccp@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 5/5] net: dccp: fix sign bug

From: Kulikov Vasiliy <segooon@...il.com>
Date: Sat, 17 Jul 2010 19:21:00 +0400

> 'gap' is unsigned, so this code is wrong:
> 
>     gap = -new_head;
>     ...
>     if (gap > 0) { ... }
> 
> Make 'gap' signed.
> 
> 
> The semantic patch that finds this problem (many false-positive results):
> (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Kulikov Vasiliy <segooon@...il.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html