netdev - Re: [PATCH v4 2.6.35-rc3] drivers/net: ks8842 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100719154500.a7cc2fb7.akpm@linux-foundation.org>
Date:	Mon, 19 Jul 2010 15:45:00 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Miller <davem@...emloft.net>
Cc:	David.Choi@...rel.Com, netdev@...r.kernel.org,
	Charles.Li@...rel.Com, horms@...ge.net.au
Subject: Re: [PATCH v4 2.6.35-rc3] drivers/net: ks8842 driver

On Mon, 19 Jul 2010 15:26:21 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> David Choi, I'm quite upset, this shows that you did not test the
> 16-bit code paths (the whole _point_ of this change) at all.

The code could have passed runtime testing by luck.

> You didn't even validate the build for new warnings.

yeah.  The kernel build is such a stinky mess of warnings that it's
easy to miss new ones.  You're basically forced to manually compile the
files which you touched to see if you added warnings.

That's pretty easy to do:

- unapply your patch
- make
- apply your patch
- make

and `make' will go and build just the files you affected.

We really should be more aggressive about all those warnings though.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html