netdev - Re: [B.A.T.M.A.N.] [PATCH] net: Add batman-adv meshing protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTim4QSjgC2BbrEJEpefQahbkSgaRPPfJ-N0aPL-E@mail.gmail.com>
Date:	Tue, 20 Jul 2010 13:41:35 -0500
From:	Abraham Arce <abraham.arce.moreno@...il.com>
To:	Marek Lindner <lindner_marek@...oo.de>
Cc:	b.a.t.m.a.n@...ts.open-mesh.org,
	David Miller <davem@...emloft.net>, sven.eckelmann@....de,
	netdev@...r.kernel.org, siwu@....tu-chemnitz.de
Subject: Re: [B.A.T.M.A.N.] [PATCH] net: Add batman-adv meshing protocol

Hi,

On Tue, Jul 20, 2010 at 1:23 PM, Marek Lindner <lindner_marek@...oo.de> wrote:
> On Tuesday, July 20, 2010 18:59:28 David Miller wrote:
>> Whoever you leave it to, this needs to be fixed up before this
>> code can be integrated.  So if those people are not active or
>> don't have time, you very much should consider the reality that
>> you might have to do these fixups yourself.
>
> No worries - we are quite alive and follow the discussion closely. The raised
> issues will be addressed pretty soon.
>
> @Sven: I think you do a great job integrating all those patches and trees.
> Your helping hand would be really missed.  :)

Minor comments...

1. Is it ok to have a README in drivers directory? why not moving it
to Documentation/networking?
2. Compilation error, one extra arguments passed

- stats = (struct net_device_stats *)dev_get_stats(skb->dev, &temp);
+ stats = (struct net_device_stats *)dev_get_stats(skb->dev, &temp);

  LD      kernel/built-in.o
net/batman-adv/hard-interface.c: In function 'batman_skb_recv':
net/batman-adv/hard-interface.c:482: error: too many arguments to
function 'dev_get_stats'
make[2]: *** [net/batman-adv/hard-interface.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [net/batman-adv] Error 2
make: *** [net] Error 2

Best Regards
Abraham
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html