netdev - Re: [PATCH] drop_monitor: convert some kfree_skb call sites to consume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100720.132821.221599763.davem@davemloft.net>
Date:	Tue, 20 Jul 2010 13:28:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nhorman@...driver.com
Cc:	netdev@...r.kernel.org, viro@...iv.linux.org.uk, eparis@...hat.com
Subject: Re: [PATCH] drop_monitor: convert some kfree_skb call sites to
 consume_skb

From: Neil Horman <nhorman@...driver.com>
Date: Tue, 20 Jul 2010 12:45:56 -0400

> Convert a few calls from kfree_skb to consume_skb
> 
> Noticed while I was working on dropwatch that I was detecting lots of internal
> skb drops in several places.  While some are legitimate, several were not,
> freeing skbs that were at the end of their life, rather than being discarded due
> to an error.  This patch converts those calls sites from using kfree_skb to
> consume_skb, which quiets the in-kernel drop_monitor code from detecting them as
> drops.  Tested successfully by myself
> 
> Signed-off-by: Neil Horman <nhorman@...driver.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html