netdev - Re: net/dsa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100720135950.GZ14513@mail.wantstofly.org>
Date:	Tue, 20 Jul 2010 15:59:50 +0200
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Karl Beldan <karl.beldan@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: net/dsa

On Mon, Jul 12, 2010 at 10:59:29PM +0200, Karl Beldan wrote:

> Hi,

Hi Karl,

Sorry, I didn't see your mail initially -- please CC me in the future.

> I found the dsa code very handy to help manage a switch.

Ah.  What particular part are you using?

> Yet I was surprised I had to tweak the code to simply use the phy
> layer state machine.

You mean that net/dsa uses phy_attach() but not phy_start_machine() ?
Have you seen problems arising from this?

> And I don't see much activity in the code nor any discussion, e.g no
> follow up to http://patchwork.ozlabs.org/patch/16578.
> 
> So I was wondering if there was anybody playing with this code, or
> having ideas about features to add (vlan/stp callbacks) ?

As far as I know, the code currently in the kernel works well for what
it intends to do (which is to just expose the switch ports), and I'm
not aware of any bugs in it.

That said, you're right in that there are several more features that
the hardware supports that the software could be extended to handle.

For one, I don't have access to any Marvell switch chip hardware
anymore, so that limits my ability to play with this.  Also, the
relevant documentation is under a rather restrictive license, so the
only way I can see net/dsa support for Marvell parts improving is if
there's pressure from a large enough customer to make this happen.

If this is about non-Marvell parts, I'd welcome adding support for
those into net/dsa.  For one, I would really like to see Broadcom
switch chip support added -- the documentation for those chips is
under similarly restrictive licensing, though.

thanks,
Lennert
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html