netdev - RE: [PATCH net-2.6] ixgbe/igb: catch invalid VF settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43F901BD926A4E43B106BF17856F0755F18462F6@orsmsx508.amr.corp.intel.com>
Date:	Wed, 21 Jul 2010 13:23:46 -0700
From:	"Rose, Gregory V" <gregory.v.rose@...el.com>
To:	Chris Wright <chrisw@...s-sol.org>,
	Andy Gospodarek <andy@...yhouse.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-2.6] ixgbe/igb: catch invalid VF settings

>-----Original Message-----
>From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
>On Behalf Of Chris Wright
>Sent: Wednesday, July 21, 2010 9:51 AM
>To: Andy Gospodarek
>Cc: netdev@...r.kernel.org; chrisw@...s-sol.org
>Subject: Re: [PATCH net-2.6] ixgbe/igb: catch invalid VF settings
>
>* Andy Gospodarek (andy@...yhouse.net) wrote:
>> Some ixgbe cards put an invalid VF device ID in the PCIe SR-IOV
>> capability.  The ixgbe driver is only valid for PFs or non SR-IOV
>> hardware.  It seems that the same problem could occur on igb hardware
>as
>> well, so if we discover we are trying to initialize a VF in
>ixbge_probe
>> or igb_probe, print an error and exit.
>>
>> Based on a patch for ixgbe from Chris Wright <chrisw@...s-sol.org>.
>>
>> Signed-off-by: Andy Gospodarek <andy@...yhouse.net>
>> Cc: Chris Wright <chrisw@...s-sol.org>
>
>Acked-by: Chris Wright <chrisw@...s-sol.org>
>
>Only seen this on ixgbe, but since the result there is a kernel panic
>makes sense to be defensive.
>
>thanks,
>-chris

Acked-by: Greg Rose <gregory.v.rose@...el.com>

Looks good, thanks.

- Greg

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html