lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Jul 2010 04:38:24 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Jeff Kirsher <jeffrey.t.kirsher@...el.com> Cc: David Miller <davem@...emloft.net>, Jesse Brandeburg <jesse.brandeburg@...el.com>, PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net-next-2.6] ixgbe: fix ethtool stats Le mardi 20 juillet 2010 à 15:06 -0700, Jeff Kirsher a écrit : > On Tue, Jul 20, 2010 at 10:28, Eric Dumazet <eric.dumazet@...il.com> wrote: > > Note : I am currently unable to test following patch, could you please > > Intel guys test it and Ack (or Nack) it ? > > > > Thanks ! > > > > [PATCH net-next-2.6] ixgbe: fix ethtool stats > > > > In latest changes about 64bit stats on 32bit arches, > > [commit 28172739f0a276eb8 (net: fix 64 bit counters on 32 bit arches)], > > I missed ixgbe uses a bit of magic in its ixgbe_gstrings_stats > > definition. > > > > IXGBE_NETDEV_STAT() must now assume offsets relative to > > rtnl_link_stats64, not relative do dev->stats. > > > > As a bonus, we also get 64bit stats on ethtool -S > > > > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com> > > --- > > drivers/net/ixgbe/ixgbe_ethtool.c | 42 ++++++++++++++-------------- > > 1 file changed, 21 insertions(+), 21 deletions(-) > > > > Thanks Eric, I have added it to my queue. > Thanks ! By the way, my ixgbe conf doesnt like net-next-2.6 at all. (No link is established in my fiber loop configuration) current linux-2.6 git runs correctly, link at 10Gb, so there is a regression somewhere. As this machine is quite slow (I dont have anymore my Nehalem dev machine, had to use an old setup), a bisection would take one month... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists