netdev - Re: [PATCH] e1000e: Fix irq_synchronize in MSI-X case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 21 Jul 2010 13:38:10 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jean Delvare <jdelvare@...e.de>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Bruce Allan <bruce.w.allan@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [PATCH] e1000e: Fix irq_synchronize in MSI-X case

On Tue, Jul 20, 2010 at 08:12, Jean Delvare <jdelvare@...e.de> wrote:
> Synchronize all IRQs when in MSI-X IRQ mode.
>
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Bruce Allan <bruce.w.allan@...el.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>
> ---
> I sent this patch to the e1000-devel list on June 8th, 2010, but
> didn't receive any answer:
> http://sourceforge.net/mailarchive/forum.php?thread_name=201006081818.59098.jdelvare%40suse.de&forum_name=e1000-devel
>
> I don't know how critical synchronize_irq() is, so I don't know if
> this patch should go to stable branches or not.
>
>  drivers/net/e1000e/netdev.c |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> --- a/drivers/net/e1000e/netdev.c
> +++ b/drivers/net/e1000e/netdev.c
> @@ -1939,7 +1939,13 @@ static void e1000_irq_disable(struct e10
>        if (adapter->msix_entries)
>                ew32(EIAC_82574, 0);
>        e1e_flush();
> -       synchronize_irq(adapter->pdev->irq);
> +
> +       if (adapter->msix_entries) {
> +               synchronize_irq(adapter->msix_entries[0].vector);
> +               synchronize_irq(adapter->msix_entries[1].vector);
> +               synchronize_irq(adapter->msix_entries[2].vector);
> +       } else
> +               synchronize_irq(adapter->pdev->irq);
>  }
>
>  /**
>
> --
> Jean Delvare
> Suse L3

Thanks, I have added the patch to my queue.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html