netdev - Re: [patch 2/3] arch/um/drivers: remove duplicate structure field initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100721.111737.158419467.davem@davemloft.net>
Date:	Wed, 21 Jul 2010 11:17:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	netdev@...r.kernel.org, julia@...u.dk, shemminger@...tta.com
Subject: Re: [patch 2/3] arch/um/drivers: remove duplicate structure field
 initialization

From: akpm@...ux-foundation.org
Date: Tue, 20 Jul 2010 15:25:17 -0700

> From: Julia Lawall <julia@...u.dk>
> 
> There are two initializations of ndo_set_mac_address, one to a local
> function that is not used otherwise and one to a function that is defined
> elsewhere.
> 
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
 ...
> 
> akpm:
> 
> - Use the standard eth_mac_addr() in uml_net_set_mac()
> 
> - Remove unneeded and racy local set_ether_mac()
> 
> - Remove duplicated (and incorrect)
>   uml_netdev_ops.ndo_set_mac_address initializer.
> 
> Fixes 8bb95b39a16ed55226810596f92216c53329d2fe ("uml: convert network
> device to netdevice ops").
> 
> [akpm@...ux-foundation.org: rework as above]
> Signed-off-by: Julia Lawall <julia@...u.dk>
> Cc: Stephen Hemminger <shemminger@...tta.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html