netdev - Re: [PATCH] iproute2: use int instead of long for RTAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Jul 2010 09:01:39 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Ulrich Weber <uweber@...aro.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] iproute2: use int instead of long for RTAX_HOPLIMIT
 compare

On Fri, 23 Jul 2010 15:39:10 +0200
Ulrich Weber <uweber@...aro.com> wrote:

> otherwise "if ((int)val == -1)" will never match on 64 bit systems
> 
> Signed-off-by: Ulrich Weber <uweber@...aro.com>
> ---
>  ip/iproute.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/ip/iproute.c b/ip/iproute.c
> index 04b253a..711576e 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -494,7 +494,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
>  			val = *(unsigned*)RTA_DATA(mxrta[i]);
>  			switch (i) {
>  			case RTAX_HOPLIMIT:
> -				if ((long)val == -1)
> +				if ((int)val == -1)
>  					val = 0;
>  				/* fall through */
>  			default:

All applied

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html