netdev - Re: [PATCH] net: s2io: fix buffer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100723.130604.15256955.davem@davemloft.net>
Date:	Fri, 23 Jul 2010 13:06:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	segooon@...il.com
Cc:	kernel-janitors@...r.kernel.org, ramkrishna.vepa@...r.com,
	sivakumar.subramani@...r.com, sreenivasa.honnur@...r.com,
	jon.mason@...r.com, joe@...ches.com, jpirko@...hat.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: s2io: fix buffer overflow

From: Kulikov Vasiliy <segooon@...il.com>
Date: Fri, 23 Jul 2010 20:36:15 +0400

> vpd_data[] is allocated as kmalloc(256, GFP_KERNEL), so if cnt = 255
> then (cnt + 3) overflows 256. memset() is executed without checking.
> vpd_data[cnt+2] must be less than 256-cnt-2 as the latter is number of
> vpd_data[] elements to copy.
> 
> Do not fill with zero the beginning of nic->serial_num as it will
> be filled with vpd_data[].
> 
> String in product_name[] should be terminated by '\0'.
> 
> Signed-off-by: Kulikov Vasiliy <segooon@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html