[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20100724.204330.189711808.davem@davemloft.net>
Date: Sat, 24 Jul 2010 20:43:30 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: jeffrey.t.kirsher@...el.com
Cc: netdev@...r.kernel.org, gospo@...hat.com, bphilips@...ell.com,
eric.dumazet@...il.com
Subject: Re: [net-next-2.6 PATCH] ixgbe: fix ethtool stats
From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Fri, 23 Jul 2010 16:44:21 -0700
> From: Eric Dumazet <eric.dumazet@...il.com>
>
> In latest changes about 64bit stats on 32bit arches,
> [commit 28172739f0a276eb8 (net: fix 64 bit counters on 32 bit arches)],
> I missed ixgbe uses a bit of magic in its ixgbe_gstrings_stats
> definition.
>
> IXGBE_NETDEV_STAT() must now assume offsets relative to
> rtnl_link_stats64, not relative do dev->stats.
>
> As a bonus, we also get 64bit stats on ethtool -S
>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Tested-by: Stephen Ko <stephen.s.ko@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists