[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20100725.220348.48497105.davem@davemloft.net>
Date: Sun, 25 Jul 2010 22:03:48 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: joe@...ches.com
Cc: ron.mercer@...gic.com, linux-driver@...gic.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] drivers/net/qla3xxx.c: Checkpatch cleanups
From: Joe Perches <joe@...ches.com>
Date: Thu, 22 Jul 2010 18:36:17 -0700
> Remove typedefs
> Indentation and spacing
> Use a temporary for a very long pointer variable
> More 80 column compatible
> Convert a switch to if/else if
>
> Compile tested only, depends on patch "Update logging message style"
>
> (old)
> $ scripts/checkpatch.pl -f drivers/net/qla3xxx.c | grep "^total:"
> total: 209 errors, 82 warnings, 3995 lines checked
>
> (new)
> $ scripts/checkpatch.pl -f drivers/net/qla3xxx.c | grep "^total:"
> total: 2 errors, 0 warnings, 3970 lines checked
>
> $ size drivers/net/qla3xxx.o.*
> text data bss dec hex filename
> 50413 212 13864 64489 fbe9 drivers/net/qla3xxx.o.old
> 49959 212 13728 63899 f99b drivers/net/qla3xxx.o.new
>
> Signed-off-by: Joe Perches <joe@...ches.com>
Also applied, thanks Joe.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists