[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <FE86E729-1744-4D87-BEDA-68453C7F8B09@vmware.com>
Date: Mon, 26 Jul 2010 05:10:55 -0700
From: Bhavesh Davda <bhavesh@...are.com>
To: David Miller <davem@...emloft.net>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2.6.35-rc1] net-next: Fix an overflow bug in vmxnet3 Tx
descriptor
Sorry about that. I'll keep that in mind for future patches. Thanks for fixing up and commiting this patch.
Regards
- Bhavesh
(From my iPhone)
On Jul 25, 2010, at 5:05 PM, "David Miller" <davem@...emloft.net> wrote:
> From: Bhavesh Davda <bhavesh@...are.com>
> Date: Sat, 24 Jul 2010 17:43:29 -0700
>
>> ---
>
> If you put the "---" there are the beginning of your message,
> the whole commit message is discarded by GIT.
>
> I said you should put "---" at the end of the commit message,
> when you want to add more side commentary that should not appear
> in the commit message but is for people in this thread to read.
>
> I fixed this up when adding your patch, but I have no idea why
> you did this. Please don't do it again.
>
>> Fix an overflow bug in vmxnet3 Tx descriptor
>>
>> This patch fixes a bug where a 16K buffer on a Tx descriptor was overflowing
>> into the 'gen' bit in the descriptor thereby corrupting the descriptor and
>> stalling the transmit ring.
>>
>> Signed-off-by: Bhavesh Davda <bhavesh@...are.com>
>> Signed-off-by: Shreyas Bhatewara <sbhatewara@...are.com>
>> Signed-off-by: Matthew Delco <delcoM@...are.com>
>> Signed-off-by: Ronghua Zhang <ronghua@...are.com>
>
> Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists