netdev - Re: [PATCH] wireless: Make COMPAT_NETLINK_MESSAGES depend upon WEXT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1280175534.20917.2.camel@jlt3.sipsolutions.net>
Date:	Mon, 26 Jul 2010 22:18:54 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH] wireless: Make COMPAT_NETLINK_MESSAGES depend upon
 WEXT_CORE

On Mon, 2010-07-26 at 13:15 -0700, David Miller wrote:
> WIRELESS_EXT is not the correct dependency.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
> 
> Wireless folks, just FYI, I will commit this to net-next-2.6
> 
>  net/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/Kconfig b/net/Kconfig
> index b325094..e24fa08 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -32,7 +32,7 @@ config WANT_COMPAT_NETLINK_MESSAGES
>  config COMPAT_NETLINK_MESSAGES
>  	def_bool y
>  	depends on COMPAT
> -	depends on WIRELESS_EXT || WANT_COMPAT_NETLINK_MESSAGES
> +	depends on WEXT_CORE || WANT_COMPAT_NETLINK_MESSAGES

You're right, thank you, I missed that at the time I changed this.

FWIW, it seems I broke this in 2.6.32! Guess nobody noticed since most
people actually do still have WIRELESS_EXT, especially distros.

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html