| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Jul 2010 16:08:19 -0700 From: Jeff Kirsher <jeffrey.t.kirsher@...el.com> To: Sonny Rao <sonnyrao@...ibm.com> Cc: netdev@...r.kernel.org, e1000-devel@...ts.sf.net Subject: Re: [PATCHv3] Add missing memory barriers to clean_rx_irq functions in Intel Drivers On Tue, Jul 27, 2010 at 16:05, Sonny Rao <sonnyrao@...ibm.com> wrote: > On Tue, Jul 27, 2010 at 03:45:42PM -0700, Jeff Kirsher wrote: >> >> You also seem to be missing igb. > > This patch is similar to what was fixed in ixgbe in this patch: > > http://marc.info/?l=e1000-devel&m=126593062701537&w=3 > > We should add read memory barriers to all the similar cases across the > Intel ethernet driver family. In the case of ixgbevf, igb, and igbvf > I've also added a missing barrier to the clean_tx_irq path because I > missed it in my last patch. > > Without the barrier a processor can speculate a load ahead of the load > which looks at the status bit and get stale information causing a > number of different issues including invalid packet length, NULL > pointers, or bad data since checksumming was assumed to be done > in hardware. > > v2: I missed the e100 the first time > v3: I missed igb and igbvf, third time's the charm? > > Signed-off-by: Milton Miller <miltonm@....com> > Signed-off-by: Sonny Rao <sonnyrao@...ibm.com> > cc: stable <stable@...nel.org> > Thanks, I have added the patch to my queue. -- Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists