lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Jul 2010 20:45:45 -0700 (PDT) From: David Miller <davem@...emloft.net> To: peppe.cavallaro@...com Cc: netdev@...r.kernel.org Subject: Re: [net-next 3/3] stmmac: fix automatic PAD/FCS stripping From: Giuseppe CAVALLARO <peppe.cavallaro@...com> Date: Tue, 27 Jul 2010 12:09:47 +0200 > For Simple Ethernet frames (802.2 and 802.3) the GMAC Core > never strips pad and fcs. This means the ACS has no effect > on IPv4/6 frames. > The FL bits, in the RDES0, include the FCS so the driver > has to remove it in SW. > For 802.3 frame format with LLC or LLC-SNAP, when set the ACS > bit, the HW strips both PAD and FCS. > The FL bits, in the RDES0, actually represents the frame length > already stripped. > This patch fixes this logic within the device driver that > erroneously removed 4byte from 802.3 frames already stripped > corrupting the payload. > > Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists