netdev - Re: [PATCH net-next 0/8] bnx2x: move bnx2x to separate folder and divide to files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100727.205640.235673886.davem@davemloft.net>
Date:	Tue, 27 Jul 2010 20:56:40 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dmitry@...adcom.com
Cc:	netdev@...r.kernel.org, eilong@...adcom.com
Subject: Re: [PATCH net-next 0/8] bnx2x: move bnx2x to separate folder and
 divide to files

From: David Miller <davem@...emloft.net>
Date: Tue, 27 Jul 2010 20:36:40 -0700 (PDT)

> From: "Dmitry Kravkov" <dmitry@...adcom.com>
> Date: Wed, 28 Jul 2010 01:40:47 +0300
> 
>> resubmit the series with fixes for git-apply. Thanks
> 
> All applied, thanks.

Ummm, so what in the world did you think was going to happen
the next time I try to merge net-2.6 into net-next-2.6?

Any clue what might happen?

Any idea?

Since you not only moved the driver into a new directory,
but also moved functions all over the damn place into new
files too, the bnx2x bug fixes in net-2.6 have to be applied
by hand by me during the merge, bit by bit.

This is one of the millions of reasons I absolutely detest multi-file
drivers, people move crap around, patches from one tree can't easily
be munged into another, etc.

If it's too big to fit in one file, your driver is too damn bloated.
End of story.  Put the thing into one file under drivers/net and
simplify _everyones_ life.

I'm fixing this merge mess up, but I'm very not happy about how
you guys staged this sequence of events.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html