netdev - Re: RPS vs. hard-irq-context netif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1280496115.3710.20.camel@jlt3.sipsolutions.net>
Date:	Fri, 30 Jul 2010 15:21:55 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	netdev <netdev@...r.kernel.org>
Subject: Re: RPS vs. hard-irq-context netif_rx()

On Fri, 2010-07-30 at 15:03 +0200, Johannes Berg wrote:

> The reason seems to be that
>  * RCU_TREE uses local_bh_disable/enable
>  * CONFIG_RPS uses RCU within netif_rx()
>  * the driver I'm using calls netif_rx() within the irq context
> 
> So .. where's the bug? I'd point to CONFIG_RPS since it's newest.

Disabling RPS gives me the same result due to netpoll since

commit de85d99eb7b595f6751550184b94c1e2f74a828b
Author: Herbert Xu <herbert@...dor.apana.org.au>
Date:   Thu Jun 10 16:12:44 2010 +0000

    netpoll: Fix RCU usage

Disabling netpoll as well gets me a warning-free boot, but I suspect
that's not really what it should be like...

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html