[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20100730.232848.115930956.davem@davemloft.net>
Date: Fri, 30 Jul 2010 23:28:48 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: fubar@...ibm.com
Cc: andy@...yhouse.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bonding: take rtnl in bond_loadbalance_arp_mon
From: Jay Vosburgh <fubar@...ibm.com>
Date: Thu, 29 Jul 2010 10:49:51 -0700
> Andy Gospodarek <andy@...yhouse.net> wrote:
>
>>[PATCH net-next] bonding: prevent sysfs from allowing arp monitoring with alb/tlb
>>
>>When using module options arp monitoring and balance-alb/balance-tlb
>>are mutually exclusive options. Anytime balance-alb/balance-tlb are
>>enabled mii monitoring is forced to 100ms if not set. When configuring
>>via sysfs no checking is currently done.
>>
>>Handling these cases with sysfs has to be done a bit differently because
>>we do not have all configuration information available at once. This
>>patch will not allow a mode change to balance-alb/balance-tlb if
>>arp_interval is already non-zero. It will also not allow the user to
>>set a non-zero arp_interval value if the mode is already set to
>>balance-alb/balance-tlb. They are still mutually exclusive on a
>>first-come, first serve basis.
>>
>>Tested with initscripts on Fedora and manual setting via sysfs.
>>
>>Signed-off-by: Andy Gospodarek <gospo@...hat.com>
>
> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>
Applied, thanks guys.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists