netdev - Re: [PATCH 1/2] nf_nat: make unique

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.01.1007311352490.17359@obet.zrqbmnf.qr>
Date:	Sat, 31 Jul 2010 13:54:42 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Changli Gao <xiaosuo@...il.com>
cc:	Patrick McHardy <kaber@...sh.net>,
	"David S. Miller" <davem@...emloft.net>,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] nf_nat: make unique_tuple return void

On Saturday 2010-07-31 04:15, Changli Gao wrote:

>the only user of unique_tuple() get_unique_tuple() doesn't care about the
>return value of unique_tuple(), so make unique_tuple() return void (nothing).

Shouldn't the callers (get_unique_tuple in nf_nat_core.c) ideally 
return NF_DROP or something such that connections that cannot be 
uniquely mangled be rejected rather than forwarded without mangling?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html