lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 31 Jul 2010 22:07:38 +0800 From: Changli Gao <xiaosuo@...il.com> To: Jan Engelhardt <jengelh@...ozas.de> Cc: Patrick McHardy <kaber@...sh.net>, "David S. Miller" <davem@...emloft.net>, netfilter-devel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 2/2] nf_nat: don't check if the tuple is unique when there isn't any other choice On Sat, Jul 31, 2010 at 10:03 PM, Jan Engelhardt <jengelh@...ozas.de> wrote: > > On Saturday 2010-07-31 04:22, Changli Gao wrote: >>+++ b/net/ipv4/netfilter/nf_nat_proto_common.c >>@@ -81,9 +81,9 @@ void nf_nat_proto_unique_tuple(struct nf_conntrack_tuple *tuple, >> else >> off = *rover; >> >>- for (i = 0; i < range_size; i++, off++) { >>+ for (i = 0; 1; off++) { > > The 1 looks strange. It's more common to express this without > a condition, as in (i = 0; ; ++off). > > OK, Thanks. -- Regards, Changli Gao(xiaosuo@...il.com) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists