netdev - Re: [PATCH v4] can: Add driver for esd CAN-USB/2 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100730.215742.71118882.davem@davemloft.net>
Date:	Fri, 30 Jul 2010 21:57:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	matthias.fuchs@....eu
Cc:	netdev@...r.kernel.org, Socketcan-core@...ts.berlios.de,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH v4] can: Add driver for esd CAN-USB/2 device

From: Matthias Fuchs <matthias.fuchs@....eu>
Date: Tue, 27 Jul 2010 15:42:40 +0200

> +#ifdef CONFIG_SYSFS
> +	if (device_create_file(&intf->dev, &dev_attr_firmware))
> +		dev_err(&intf->dev,
> +			"Couldn't create device file for firmware\n");

This ifdef protection is unnecessary, device_create_file() et al.
are available always, so please remove these SYSFS ifdef tests.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html