netdev - [PATCH 19/29] LMC: Remove sc->check. We don't do such checks in drivers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1280588752-9340-19-git-send-email-khc@pm.waw.pl>
Date:	Sat, 31 Jul 2010 17:05:42 +0200
From:	Krzysztof Halasa <khc@...waw.pl>
To:	David Miller <davem@...emloft.net>
Cc:	<netdev@...r.kernel.org>
Subject: [PATCH 19/29] LMC: Remove sc->check. We don't do such checks in drivers.

From: Krzysztof Hałasa <khc@...waw.pl>

Signed-off-by: Krzysztof Hałasa <khc@...waw.pl>
---
 drivers/net/wan/lmc/main.c |    9 ---------
 drivers/net/wan/lmc/var.h  |    2 --
 2 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/drivers/net/wan/lmc/main.c b/drivers/net/wan/lmc/main.c
index 6698aa9..56631d4 100644
--- a/drivers/net/wan/lmc/main.c
+++ b/drivers/net/wan/lmc/main.c
@@ -575,14 +575,6 @@ static void lmc_watchdog(unsigned long data)
 
 	spin_lock_irqsave(&sc->lock, flags);
 
-	if (sc->check != 0xBEAFCAFE) {
-		printk(KERN_ERR
-		       "LMC: Corrupt net_device struct, breaking out\n");
-		spin_unlock_irqrestore(&sc->lock, flags);
-		return;
-	}
-
-
 	/* Make sure the tx jabber and rx watchdog are off,
 	 * and the transmit and receive processes are running.
 	 */
@@ -761,7 +753,6 @@ static int __devinit lmc_init_one(struct pci_dev *pdev,
 	dev->tx_queue_len = 100;
 	sc->netdev = dev;
 	sc->name = dev->name;
-	sc->check = 0xBEAFCAFE;
 	dev->base_addr = pci_resource_start(pdev, 0);
 	dev->irq = pdev->irq;
 	pci_set_drvdata(pdev, dev);
diff --git a/drivers/net/wan/lmc/var.h b/drivers/net/wan/lmc/var.h
index a3e9aee..10cb70d 100644
--- a/drivers/net/wan/lmc/var.h
+++ b/drivers/net/wan/lmc/var.h
@@ -320,8 +320,6 @@ struct card {
 
 	u8 failed_ring;			/* Failure cases */
 	u8 failed_recv_alloc;
-
-	u32 check;			/* Structure check */
 };
 
 #define PKT_BUF_SZ		1542
-- 
1.7.1.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html