netdev - Re: [PATCH] tcp: cookie transactions setsockopt memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100730.230524.39186905.davem@davemloft.net>
Date:	Fri, 30 Jul 2010 23:05:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dp@...hloadlab.com
Cc:	kuznet@....inr.ac.ru, jmorris@...ei.org, kaber@...sh.net,
	pekkas@...core.fi, yoshfuji@...ux-ipv6.org, eric.dumazet@...il.com,
	ilpo.jarvinen@...sinki.fi, akpm@...ux-foundation.org,
	steve@...idescorp.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, william.allen.simpson@...il.com
Subject: Re: [PATCH] tcp: cookie transactions setsockopt memory leak

From: Dmitry Popov <dp@...hloadlab.com>
Date: Thu, 29 Jul 2010 15:59:36 +0400

> From: Dmitry Popov <dp@...hloadlab.com>
> 
> There is a bug in do_tcp_setsockopt(net/ipv4/tcp.c),
> TCP_COOKIE_TRANSACTIONS case.
> In some cases (when tp->cookie_values == NULL) new tcp_cookie_values
> structure can be allocated (at cvp), but not bound to
> tp->cookie_values. So a memory leak occurs.
> 
> Signed-off-by: Dmitry Popov <dp@...hloadlab.com>

Applied and queued up for -stable, thanks Dmitry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html