netdev - Re: [PATCH] can-raw: Fix skb_orphan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1280852081.3266.834.camel@pohly-mobl1.ikn.intel.com>
Date:	Tue, 03 Aug 2010 18:14:41 +0200
From:	Patrick Ohly <patrick.ohly@...el.com>
To:	Oliver Hartkopp <socketcan@...tkopp.net>
Cc:	David Miller <davem@...emloft.net>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"socketcan-core@...ts.berlios.de" <socketcan-core@...ts.berlios.de>,
	"matthias.fuchs@....eu" <matthias.fuchs@....eu>
Subject: Re: [PATCH] can-raw: Fix skb_orphan_try handling

On Tue, 2010-08-03 at 18:22 +0300, Oliver Hartkopp wrote:
> >> The flags are tested all together in skb_orphan_try() ...
> > 
> > This is why I hate using unions in situations like this... it makes
> > code impossible to audit easily.
> > 
> > This damn thing should just be a "u8 flags" and a bunch of bit mask
> > CPP macro defines for the various boolean values.
> 
> Yep! I also felt like this.
> 
> Maybe Patrick Ohly can give some feedback, if he's ok with that kind of
> change. So far there are only a few places that would need to be changed for
> the flags bitops.

I'm fine with using a simple u8. I'm not sure where I picked up the
union thing, it's not something that I usually do in my own code.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html