netdev - Re: softirq warnings when calling dev_kfree_skb_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C5834C4.3070103@goop.org>
Date:	Tue, 03 Aug 2010 08:24:52 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	David Miller <davem@...emloft.net>
CC:	johannes@...solutions.net, netdev@...r.kernel.org,
	dongxiao.xu@...el.com, Xen-devel@...ts.xensource.com,
	Ian.Campbell@...rix.com, kaber@...sh.net, eric.dumazet@...il.com
Subject: Re: softirq warnings when calling dev_kfree_skb_irq - bug in conntrack?

  On 08/03/2010 12:23 AM, David Miller wrote:
> From: Johannes Berg<johannes@...solutions.net>
> Date: Tue, 03 Aug 2010 09:04:34 +0200
>
>> I had this too:
>> http://article.gmane.org/gmane.linux.network/167590
>>
>> But I'm not convinced it's conntrack, I'd think it's
>>
>> commit 15e83ed78864d0625e87a85f09b297c0919a4797
>> Author: Eric Dumazet<eric.dumazet@...il.com>
>> Date:   Wed May 19 23:16:03 2010 +0000
>>
>>      net: remove zap_completion_queue
>>
>> which, from the looks of it, ought to be reverted because it failed to
>> take into account that dev_kfree_skb() can do more things that require
>> non-irq-context than just calling skb->destructor, like for instance the
>> conntrack thing we see here.
> Agreed.  I'll revert this and queue that up for 2.6.35-stable
>

FWIW I only see this in linux-next, not released 2.6.35.  But it does 
look like a likely root cause.

     J
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html