netdev - RE: Receive processing stops when dev->poll returns 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7866DA1F8D2D4541B87FEE88E633ABAA2B72082003@MNEXMB1.qlogic.org>
Date:	Thu, 5 Aug 2010 13:11:07 -0500
From:	Usha Srinivasan <usha.srinivasan@...gic.com>
To:	Stephen Hemminger <shemminger@...tta.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: Receive processing stops when dev->poll returns 1

Stephen,
The min is inside a while loop; it is purely used to limit the number of completions that are retrieved at-a-time.  The outer while loops ensuring that all the completions are handled until budget is reached or there are no completions left. Please look again at the code I sent you.
Usha

-----Original Message-----
From: Stephen Hemminger [mailto:shemminger@...tta.com] 
Sent: Thursday, August 05, 2010 1:37 PM
To: Usha Srinivasan
Cc: netdev@...r.kernel.org
Subject: Re: Receive processing stops when dev->poll returns 1

On Thu, 5 Aug 2010 11:36:26 -0500
Usha Srinivasan <usha.srinivasan@...gic.com> wrote:

>         int max = (budget - done);
>         t = min(<max-supported-by-driver>, max);
>         n = get-completions(comp_list);

You need to handle all completions pending in the poll, the code will
not call you back. So this min() is the problem.

-- 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html