netdev - Re: [patch] isdn: gigaset: add missing unlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C5EA7FA.9020504@imap.cc>
Date:	Sun, 08 Aug 2010 14:50:02 +0200
From:	Tilman Schmidt <tilman@...p.cc>
To:	Dan Carpenter <error27@...il.com>
CC:	Hansjoerg Lipp <hjlipp@....de>, Karsten Keil <isdn@...ux-pingi.de>,
	"David S. Miller" <davem@...emloft.net>,
	Andy Shevchenko <ext-andriy.shevchenko@...ia.com>,
	gigaset307x-common@...ts.sourceforge.net, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] isdn: gigaset: add missing unlock

Am 06.08.2010 10:23 schrieb Dan Carpenter:
> We should unlock here.  This is the only place where we return from the
> function with the lock held.  The caller isn't expecting it.

Thanks, good catch.

> Signed-off-by: Dan Carpenter <error27@...il.com>

Acked-by: Tilman Schmidt <tilman@...p.cc>

> 
> diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c
> index e5ea344..bcc174e 100644
> --- a/drivers/isdn/gigaset/capi.c
> +++ b/drivers/isdn/gigaset/capi.c
> @@ -1052,6 +1052,7 @@ static inline void remove_appl_from_channel(struct bc_state *bcs,
>  	do {
>  		if (bcap->bcnext == ap) {
>  			bcap->bcnext = bcap->bcnext->bcnext;
> +			spin_unlock_irqrestore(&bcs->aplock, flags);
>  			return;
>  		}
>  		bcap = bcap->bcnext;

-- 
Tilman Schmidt                    E-Mail: tilman@...p.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


Download attachment "signature.asc" of type "application/pgp-signature" (260 bytes)