netdev - Re: Latest iproute2 breaks "ip route get" command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTim4h7rTJuF7UWAE-p_4NGkrwksUjoK6m2x5BubG@mail.gmail.com>
Date:	Sun, 8 Aug 2010 21:31:41 +0200
From:	Fabio Comolli <fabio.comolli@...il.com>
To:	Andreas Henriksson <andreas@...al.se>
Cc:	Ulrich Weber <uweber@...aro.com>, netdev@...r.kernel.org
Subject: Re: Latest iproute2 breaks "ip route get" command

Yup, that seems to fix it.
You can add my Tested-By in case you need it.

Regards,
Fabio




On Sun, Aug 8, 2010 at 9:33 PM, Andreas Henriksson <andreas@...al.se> wrote:
>> The following logs should explain the problem. In short, the "ip route
>> get" command with iproute2 v. 2.6.35 does not output anything (and
>> exits with a 0). This breaks (for example) vpnc.
>
> Seems to be caused by:
>
> http://git.kernel.org/?p=linux/kernel/git/shemminger/iproute2.git;a=commitdiff;h=447928279c88b6581ae4cdc1b5ac0a9e755aff64
>
> Have no idea if this is the correct fix, but it seemed like a likely typo
> based on the changes in the above commit and that this brings the output back:
>
>
> diff --git a/ip/iproute.c b/ip/iproute.c
> index 711576e..86c7ab7 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -160,7 +160,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
>        if (r->rtm_family == AF_INET6 && table != RT_TABLE_MAIN)
>                ip6_multiple_tables = 1;
>
> -       if (filter.cloned == !(r->rtm_flags&RTM_F_CLONED))
> +       if (filter.cloned && !(r->rtm_flags&RTM_F_CLONED))
>                return 0;
>
>        if (r->rtm_family == AF_INET6 && !ip6_multiple_tables) {
>
>
>
> (PS. Sorry for not properly replying in thread, but todays mailing list
> archives seems to be extremely afraid of exposing any real mail headers
> making it hard to reply properly without having received the original mail.)
>
> --
> Andreas Henriksson
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html