lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <151621281366078@web89.yandex.ru> Date: Mon, 09 Aug 2010 19:01:17 +0400 From: Franchoze Eric <franchoze@...dex.ru> To: Jarek Poplawski <jarkao2@...il.com> Cc: David Miller <davem@...emloft.net>, shemminger@...tta.com, netdev@...r.kernel.org Subject: Re: Re: [PATCH] sfq: add dummy bind/unbind handles 08.08.10, 11:04, "Jarek Poplawski" <jarkao2@...il.com>: > David Miller wrote, On 08.08.2010 07:45: > > > From: Jarek Poplawski > > Date: Sat, 07 Aug 2010 01:17:07 +0200 > > > >> Stephen Hemminger wrote, On 07.08.2010 00:23: > >> > >>> Applying a filter to an SFQ qdisc would cause null dereference > >>> in tcf_bind_filter because although SFQ is classful it didn't > >>> have all the necessary equipment. > >>> > >>> Better alternative to changing tcf_bind API is to just fix > >>> SFQ. This should go to net-2.6 and stable. > >>> > >> > >> Hmm... FYI, actually I've sent already a similar patch to the > >> original bug report thread (except .unbind_tcf method which > >> doesn't matter for fixing this bug, so should be rather > >> implemented in a separate patch, if needed at all in this > >> case). > > > > Agreed, I can't see a way that unbind can ever be invoked > > if the bind call always returns zero. > > To tell the truth, I think unbind should be implemented anyway, > just for consistency, safety, and easier verification. But, looking > at a similar case of .get and .put in the same driver, Patrick > seemed to do it purposely, so I expected some discussion about the > rules yet, and made it minimal to ease merging to older kernels. > > Thanks, > Jarek P. > > As for me it's better to add unbind now that get unexpected null derefance in future with API changing... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists