netdev - Re: [RFC] [PATCH] Don't destroy TCP sockets twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100809213002.GA23736@gondor.apana.org.au>
Date:	Mon, 9 Aug 2010 17:30:02 -0400
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC] [PATCH] Don't destroy TCP sockets twice

Andi Kleen <andi@...stfloor.org> wrote:
> 
> While working on something else I noticed that tcp_v4/6_destroy_sock()
> can get called twice on a socket. This happens because when a reset or
> similar happens tcp_done destroys the connection socket state, and 
> then eventually when the socket is released it is destroyed again. 

I'm still having problems understanding why you're getting a call
to send a FIN after tcp_done.  This shouldn't happen at all because
tcp_done moves the socket to the TCP_CLOSE state, where FINs should
not be sent.

Can you clarify on how we can reproduce this problem in the
upstream kernel?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html