[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20100810.013447.245408526.davem@davemloft.net>
Date: Tue, 10 Aug 2010 01:34:47 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: error27@...il.com
Cc: amit.salecha@...gic.com, anirban.chakraborty@...gic.com,
linux-driver@...gic.com, sucheta.chakraborty@...gic.com,
netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch 1/2 v2] qlcnic: clean up qlcnic_init_pci_info()
From: Dan Carpenter <error27@...il.com>
Date: Tue, 10 Aug 2010 09:47:56 +0200
> In the original code we allocated memory conditionally and freed it in
> the error handling unconditionally. It turns out that this function is
> only called during initialization and "adapter->npars" and
> "adapter->eswitch" are always NULL at the start of the function. I
> removed those checks.
>
> Also since I was cleaning things, I changed the error handling for
> qlcnic_get_pci_info() and pulled everything in an indent level.
>
> Signed-off-by: Dan Carpenter <error27@...il.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists