netdev - Re: [PATCH] usbnet: rx_submit() should return an error code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Aug 2010 01:41:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	oneukum@...e.de
Cc:	ellyjones@...gle.com, stern@...land.harvard.edu,
	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	jglasgow@...gle.com
Subject: Re: [PATCH] usbnet: rx_submit() should return an error code.

From: Oliver Neukum <oneukum@...e.de>
Date: Tue, 10 Aug 2010 09:42:05 +0200

> Am Dienstag, 10. August 2010, 09:18:55 schrieb David Miller:
>> From: Elly Jones <ellyjones@...gle.com>
>> Date: Mon, 9 Aug 2010 18:37:50 -0400
>> 
>> > This patch makes rx_submit() return an error code, and makes some call sites
>> > that care check the return value. This is important because it lets us properly
>> > handle cases where the device isn't ready to handle URB submissions (e.g., when
>> > it is autosuspended under some drivers); previously, we would attempt and fail
>> > to submit URBs and reschedule ourselves to try and fail again. This patch is
>> > against Linus's 2.6 repo commit 45d7f32c7a43cbb9592886d38190e379e2eb2226.
>> > 
>> > Signed-Off-By: Elizabeth Jones <ellyjones@...gle.com>
>> 
>> What gets kevent() running again to run the rx_submit() calls when the
>> device comes back from being suspended?
>> 
> 
> usbnet_resume() schedules usbnet_bh() which will take care of that.

That makes sense, I've applied Elizabeth's patch.

But Elizabeth, your patch was severely corrupted by your email client.
Long lines were split up into two, etc.  This corrupts the patch and
makes it unusable for us.  Please make sure that you have fixed your
email client setup for the next patch you submit.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html